Todo List

Class DBusTypeMark

DBusTypeMark isn't used right now and probably won't be, we should delete it

Group DBusAuth

some SASL profiles require sending the empty string as a challenge/response, but we don't currently allow that in our protocol.

grep FIXME in dbus-auth.c

Group DBusAuth

right now sometimes both ends will block waiting for input from the other end, e.g.

Group DBusAuth

the cookie keyring needs to be cached globally not just per-auth (which raises threadsafety issues too)

Global _dbus_auth_decode_data

We need to be able to distinguish "out of memory" error from "the data is hosed" error.

Group DBusBus

right now the default address of the system bus is hardcoded, so if you change it in the global config file suddenly you have to set DBUS_SYSTEM_BUS_ADDRESS env variable.

Global dbus_bus_get

alex thinks we should nullify the connection when we get a disconnect-message.

Global dbus_bus_request_name

this all seems sort of broken.

Global _dbus_connection_block_pending_call

could use performance improvements (it keeps scanning the whole message queue for example)

Parameters:

pending

the pending call we block for a reply on

Global dbus_connection_add_filter

we don't run filters on messages while blocking without entering the main loop, since filters are run as part of dbus_connection_dispatch().

Global dbus_connection_dispatch

some FIXME in here about handling DBUS_HANDLER_RESULT_NEED_MEMORY

FIXME what if we call out to application code to handle a message, holding the dispatch lock, and the application code runs the main loop and dispatches again? Probably deadlocks at the moment.

Global dbus_connection_set_watch_functions

We need to drop the lock when we call the add/remove/toggled functions which can be a side effect of setting the watch functions.

Global dbus_connection_unref

in practice it can be quite tricky to never unref a connection that's still connected; maybe there's some way we could avoid the requirement.

Global _dbus_connection_handle_watch

This is basically a hack - we could delete _dbus_transport_handle_watch() and the virtual handle_watch in DBusTransport if we got rid of it.

Global dbus_set_error

should be called dbus_error_set()

Parameters:

error

the error.

Global dbus_set_error_const

should be called dbus_error_set_const()

Parameters:

error

the error.

Global _dbus_atomic_dec

implement arch-specific faster atomic ops

Global _dbus_atomic_inc

implement arch-specific faster atomic ops

Global _dbus_concat_dir_and_file

it might be cute to collapse multiple '/' such as "foo//" concat "//bar"

Parameters:

	dir	the directory name
	next_component	the filename

Returns:

TRUE on success

Global _dbus_directory_get_next_file

for thread safety, I think we have to use readdir_r().

Global _dbus_error_from_errno

should cover more errnos, specifically those from open().

Global _dbus_full_duplex_pipe

libdbus only uses this for the debug-pipe server, so in principle it could be in dbus-sysdeps-util.c, except that dbus-sysdeps-util.c isn't in libdbus when tests are enabled and the debug-pipe server is used.

Global _dbus_setenv

if someone can verify it's safe, we could avoid the memleak when doing an unset.

Group DBusKeyring

there's a memory leak on some codepath in here, I saw it once when running make check - probably some specific initial cookies present in the cookie file, then depending on what we do with them.

Global _dbus_keyring_validate_context

this is the most inefficient implementation imaginable.

Global _dbus_marshal_read_fixed_multi

we aren't using this function (except in the test suite)

Parameters:

	str	the string to read from
	pos	position to read from
	element_type	type of array elements
	value	place to return the array
	n_elements	number of array elements to read
	byte_order	the byte order, used to read the array length
	new_pos	NULL or location to store a position after the elements

Global _dbus_type_reader_delete

for now this does not delete the typecodes associated with the value, so this function should only be used for array elements.

Global _dbus_type_reader_set_basic

DBusTypeReader currently takes "const" versions of the type and value strings, and this function modifies those strings by casting away the const, which is of course bad if we want to get picky.

Global _dbus_type_reader_set_basic

optimize this by only rewriting until the old and new values are at the same alignment.

Global _dbus_validate_bus_name

this is inconsistent with most of DBusString in that it allows a start,len range that extends past the string end.

Global _dbus_validate_error_name

this is inconsistent with most of DBusString in that it allows a start,len range that extends past the string end.

Global _dbus_validate_interface

this is inconsistent with most of DBusString in that it allows a start,len range that extends past the string end.

Global _dbus_validate_member

this is inconsistent with most of DBusString in that it allows a start,len range that extends past the string end.

Global _dbus_validate_path

this is inconsistent with most of DBusString in that it allows a start,len range that extends past the string end.

Global _dbus_validate_path

change spec to disallow more things, such as spaces in the path name

Parameters:

	str	the string
	start	first byte index to check
	len	number of bytes to check

Returns:

TRUE if the byte range exists and is a valid name

Global _dbus_validate_signature

this is inconsistent with most of DBusString in that it allows a start,len range that extends past the string end.

Global _dbus_validate_signature_with_reason

verify that dict entries have exactly two fields

require that dict entries are in an array

Parameters:

	type_str	the string
	type_pos	where the typecodes start
	len	length of typecodes

Returns:

DBUS_VALID if valid, reason why invalid otherwise

Global _dbus_verbose_bytes

right now it prints even if not in verbose mode

Parameters:

	data	the data
	len	the length of the data
	offset	where to start counting for byte indexes

Global INITIAL_LOADER_DATA_LEN

this should be based on min header size plus some average body size, or something.

Global DBusMessageLoader

write tests for break-loader that a) randomly delete header fields and b) set string fields to zero-length and other funky values.

Global _dbus_message_loader_get_buffer

this function can be a lot more clever.

Global _dbus_message_loader_get_buffer

we need to enforce a max length on strings in header fields.

Global _dbus_message_loader_queue_messages

we need to check that the proper named header fields exist for each message type.

Global _dbus_message_loader_queue_messages

If a message has unknown type, we should probably eat it right here rather than passing it out to applications.

Global dbus_message_append_args

support DBUS_TYPE_STRUCT and DBUS_TYPE_VARIANT and complex arrays

If this fails due to lack of memory, the message is hosed and you have to start over building the whole message.

Global dbus_message_append_args_valist

for now, if this function fails due to OOM it will leave the message half-written and you have to discard the message and start over.

Global dbus_message_get_args

support DBUS_TYPE_STRUCT and DBUS_TYPE_VARIANT and complex arrays

Parameters:

	message	the message
	error	error to be filled in on failure
	first_arg_type	the first argument type
	.</dd></dl>

Global dbus_message_get_path_decomposed

this could be optimized by using the len from the message instead of calling strlen() again

Parameters:

	message	the message
	path	place to store allocated array of path components; NULL set here if no path field exists

Returns:

FALSE if no memory to allocate the array

Global dbus_message_iter_append_basic

If this fails due to lack of memory, the message is hosed and you have to start over building the whole message.

Global dbus_message_iter_append_fixed_array

If this fails due to lack of memory, the message is hosed and you have to start over building the whole message.

Global dbus_message_iter_close_container

If this fails due to lack of memory, the message is hosed and you have to start over building the whole message.

Global dbus_message_iter_init_append

If appending any of the arguments fails due to lack of memory, generally the message is hosed and you have to start over building the whole message.

Global dbus_message_iter_open_container

If this fails due to lack of memory, the message is hosed and you have to start over building the whole message.

Global _dbus_object_tree_dispatch_and_unlock

thread problems

Parameters:

	tree	the global object tree
	message	the message to dispatch

Returns:

whether message was handled successfully

Global dbus_pending_call_block

when you start blocking, the timeout is reset, but it should really only use time remaining since the pending call was created.

Global dbus_pending_call_get_completed

not thread safe? I guess it has to lock though it sucks

Parameters:

pending

the pending call

Returns:

TRUE if a reply has been received

Group DBusServer

Thread safety hasn't been looked at for DBusServer

Need notification to apps of disconnection, may matter for some transports

Global dbus_server_listen

error messages on bad address could really be better.

Group DBusString

DBusString needs a lot of cleaning up; some of the API is no longer used, and the API is pretty inconsistent.

Global _dbus_string_ends_with_c_str

memcmp might make this faster.

Global _dbus_string_equal

memcmp is probably faster

Parameters:

	a	first string
	b	second string

Returns:

TRUE if equal

Global _dbus_string_equal_substring

write a unit test

memcmp is probably faster

Parameters:

	a	first string
	a_start	where to start substring in first string
	a_len	length of substring in first string
	b	second string
	b_start	where to start substring in second string

Returns:

TRUE if the two substrings are equal

Global _dbus_string_move_len

this doesn't do anything with max_length field.

Global _dbus_string_pop_line

owen correctly notes that this is a stupid function (it was written purely for test code, e.g.

Global _dbus_string_replace_len

optimize the case where the two lengths are the same, and avoid memmoving the data in the trailing part of the string twice.

Global _dbus_string_replace_len

avoid inserting the source into dest, then deleting the replaced chunk of dest (which creates a potentially large intermediate string).

Global _dbus_string_validate_ascii

this is inconsistent with most of DBusString in that it allows a start,len range that extends past the string end.

Global _dbus_string_validate_nul

this is inconsistent with most of DBusString in that it allows a start,len range that extends past the string end.

Global _dbus_string_validate_utf8

this is inconsistent with most of DBusString in that it allows a start,len range that extends past the string end.

Global _dbus_transport_new_for_domain_socket

once we add a way to escape paths in a dbus address, this function needs to do escaping.

Global _dbus_transport_get_is_authenticated

we drop connection->mutex when calling the unix_user_function, which may not be safe really.

Global _dbus_watch_set_handler

this function only exists because of the weird way connection watches are done, see the note in docs for _dbus_connection_handle_watch().

Global dbus_g_proxy_begin_call

this particular function shouldn't die on out of memory, since you should be able to do a call with large arguments.

Global dbus_g_proxy_call_no_reply

this particular function shouldn't die on out of memory, since you should be able to do a call with large arguments.

---